Move OpenAI decorator to DFApp class
#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # azure/durable_functions/openai_agents/decorators.py # azure/durable_functions/openai_agents/model_invocation_activity.py
philliphoff
changed the title
FunctionApp classDFApp class
AnatoliB
reviewed
Sep 8, 2025
|
|
||
| return wrap | ||
|
|
||
| def _create_invoke_model_activity(self, model_provider): |
There was a problem hiding this comment.
I'm a bit concerned about bringing this much of OpenAI-related code directly into this file. Until now, all the code related to this integration was under the openai_agents folder, and I believe there is value in keeping it this way. Obviously, the entry point (durable_openai_agent_orchestrator) belongs to this class, but perhaps it can delegate to code remaining under openai_agents?
There was a problem hiding this comment.
That's fair, though I feel the app registration and "outer" activity/orchestration logic should live in this app type. I've moved the OpenAI-specific logic out.
Signed-off-by: Phillip Hoff <[email protected]>
Signed-off-by: Phillip Hoff <[email protected]>
Signed-off-by: Phillip Hoff <[email protected]>
AnatoliB
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
durable_openai_agent_orchestratordecorator to theDFAppclass. This makes it easier for developers to find as well as eliminates logic needed to scan and find theFunctionAppinstance in the startup file.